Skip to content

Display code as monospace#288

Open
kitzberger wants to merge 2 commits into
owncloud:masterfrom
kitzberger:code-monospace
Open

Display code as monospace#288
kitzberger wants to merge 2 commits into
owncloud:masterfrom
kitzberger:code-monospace

Conversation

@kitzberger

Copy link
Copy Markdown

For I find code blocks weird when they're not rendered with a monospace font ;-)

@codecov

codecov Bot commented May 27, 2020

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.79%. Comparing base (d1c5a24) to head (3b1efe8).
⚠️ Report is 215 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #288   +/-   ##
=========================================
  Coverage     66.79%   66.79%           
  Complexity       61       61           
=========================================
  Files             9        9           
  Lines           268      268           
=========================================
  Hits            179      179           
  Misses           89       89           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dj4oC dj4oC left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Security: None.
  • Stability: Single small CSS-only change (monospace font-family for code elements); low risk. Note: overlaps in intent with open PR #440, which also adds code-block CSS — recommend maintainers reconcile so only one lands to avoid conflicting selectors.
  • Performance: None.
  • Test coverage: N/A (CSS-only, no test infrastructure for styling).
  • TODOs found: 0
  • Dependency touched: no
  • CI status: not re-verified — PR is from 2018, likely needs a fresh CI run before merge

Verdict

Low-risk style tweak; comment only. Please reconcile with #440 before merging either.

🤖 Automated review by Claude Code (security · stability · performance · coverage)


Generated by Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants